Raise an exception if no sockets to poll #23

loerum · 2019-07-18T12:18:39Z

Trying to receive messages from a not registered service will create an infinite loop, the following code will print None forever:

from posttroll.subscriber import Subscribe
with Subscribe("invalid_service", "counter",) as sub:
for msg in sub.recv():
    print(msg)

It's fixed by raising an exception in Subscriber.recv if no socket to poll.

I'm some what surprised that we first see this "feature" now ... so please check if I have missed something.

coveralls · 2019-07-18T12:23:36Z

Coverage decreased (-0.09%) to 79.62% when pulling d34f427 on fix-infinite-loop into 516725e on master.

loerum · 2019-07-30T14:26:01Z

By the way, the above infinite loop, would not have happen if an addr_listener was specified:

from posttroll.subscriber import Subscribe
with Subscribe("invalid_service", "counter", addr_listener=True) as sub:
for msg in sub.recv():
    print(msg)

In this case, there is always something to poll. Maybe if a name-server is been used, addr_listener should have the default value True ?

mraspaud · 2019-07-30T17:46:06Z

I'm not in the office, please remind me to look at this next week

mraspaud

Thanks for this, could you add a small unit test for this @loerum ?

Raise an exception if no sockets to poll

d34f427

mraspaud reviewed Oct 1, 2019

View reviewed changes

mraspaud assigned loerum Oct 1, 2019

mraspaud added the enhancement label Oct 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raise an exception if no sockets to poll #23

Raise an exception if no sockets to poll #23

loerum commented Jul 18, 2019

coveralls commented Jul 18, 2019

loerum commented Jul 30, 2019

mraspaud commented Jul 30, 2019

mraspaud left a comment

Raise an exception if no sockets to poll #23

Are you sure you want to change the base?

Raise an exception if no sockets to poll #23

Conversation

loerum commented Jul 18, 2019

coveralls commented Jul 18, 2019

loerum commented Jul 30, 2019

mraspaud commented Jul 30, 2019

mraspaud left a comment

Choose a reason for hiding this comment